Skip to content

fix: preserve view descriptions on scheme import - #2886

Merged
enjeck merged 1 commit into
nextcloud:mainfrom
xhon-pelushi:fix/import-view-descriptions-2478
Aug 28, 2026
Merged

fix: preserve view descriptions on scheme import#2886
enjeck merged 1 commit into
nextcloud:mainfrom
xhon-pelushi:fix/import-view-descriptions-2478

Conversation

@xhon-pelushi

Copy link
Copy Markdown
Contributor

Summary

  • Preserve view descriptions when importing a table scheme via createFromScheme().
  • Treat empty-string descriptions as intentional updates in ViewUpdateInput, with unit coverage.

Fixes #2478

Test plan

  • Export a table with a view that has a description; import the scheme — view description should survive.
  • Empty view description still clears/updates as intended.
  • Run unit tests for ViewUpdateInput when PHP/Composer available.

@samin-z
samin-z self-requested a review August 21, 2026 08:20
@enjeck
enjeck force-pushed the fix/import-view-descriptions-2478 branch from adfe239 to d23f96d Compare August 27, 2026 05:38
Fixes nextcloud#2478

Signed-off-by: xhon-pelushi <xhon@pelushi.com>
@enjeck
enjeck force-pushed the fix/import-view-descriptions-2478 branch from d23f96d to 055752d Compare August 27, 2026 09:56
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@enjeck
enjeck merged commit 95cad0f into nextcloud:main Aug 28, 2026
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

descriptions of the views missing upon import

3 participants